stack_admn/Hi-School-Slide-Manager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Refactor slide action event bindings for improved performance and clarity. Implement namespacing to prevent duplicate event handlers and streamline edit/cancel actions. Update slide management logic to handle site data more flexibly.

Browse Source
This commit is contained in:
Stack Administrator the 3rd
2026-03-24 03:32:59 -07:00
parent 9bb2171b92
commit a18716ea6b
1 changed files with 39 additions and 53 deletions
Download Patch File Download Diff File Expand all files Collapse all files
assets/js/dashboard.js
+33 -47
View File
@@ -87,14 +87,16 @@
$targetSitesField.find('.hssm-checkboxes-compact').removeClass('hssm-field-has-error'); $targetSitesField.find('.hssm-checkboxes-compact').removeClass('hssm-field-has-error');
}); });
// Filtering and management // Filtering and management (slide row edit/delete bound in bindSlideActions after list load)
$(document).on('click', '#apply-filters', this.applyFilters.bind(this)); $(document).on('click', '#apply-filters', this.applyFilters.bind(this));
$(document).on('click', '.hssm-edit-slide', this.editSlide.bind(this));
$(document).on('click', '.hssm-delete-slide', function(e) { // Edit form actions — register once; do not re-bind in populateEditForm (prevents duplicate toasts)
$(document).on('click.hssmDashboard', '.hssm-cancel-edit, .hssm-cancel-edit-btn', (e) => {
e.preventDefault(); e.preventDefault();
const slideId = $(e.currentTarget).data('slide-id'); this.cancelEdit(e);
HSSMDashboard.deleteSlide(slideId);
}); });
$(document).on('click.hssmDashboard', '.hssm-update-slide', this.updateSlide.bind(this));
$(document).on('click.hssmDashboard', '.hssm-schedule-updated-slide', this.scheduleUpdatedSlide.bind(this));
// Analytics functionality // Analytics functionality
$(document).on('click', '#generate-report', this.generateAnalyticsReport.bind(this)); $(document).on('click', '#generate-report', this.generateAnalyticsReport.bind(this));
@@ -811,6 +813,7 @@
</button> </button>
</div> </div>
`); `);
$(document).off('click.hssmSlideActions');
return; return;
} }
@@ -830,7 +833,7 @@
slides.forEach(slide => { slides.forEach(slide => {
const imageUrl = slide.featured_image_url || ''; const imageUrl = slide.featured_image_url || '';
const statusClass = this.getStatusClass(slide.status); const statusClass = this.getStatusClass(slide.status);
const sitesText = this.formatSitesList(slide.target_sites); const sitesText = this.formatSitesList(slide.sites || slide.target_sites);
const scheduleText = this.formatScheduleText(slide); const scheduleText = this.formatScheduleText(slide);
html += ` html += `
@@ -916,29 +919,26 @@
// Bind slide action events // Bind slide action events
bindSlideActions: function() { bindSlideActions: function() {
// Edit slide // Namespaced so repeated list renders replace handlers instead of stacking
$(document).off('click', '.hssm-edit-slide').on('click', '.hssm-edit-slide', (e) => { $(document).off('click.hssmSlideActions', '.hssm-edit-slide').on('click.hssmSlideActions', '.hssm-edit-slide', (e) => {
e.preventDefault(); e.preventDefault();
const slideId = $(e.currentTarget).data('slide-id'); const slideId = $(e.currentTarget).data('slide-id');
this.editSlide(slideId); this.editSlide(slideId);
}); });
// Delete slide $(document).off('click.hssmSlideActions', '.hssm-delete-slide').on('click.hssmSlideActions', '.hssm-delete-slide', (e) => {
$(document).off('click', '.hssm-delete-slide').on('click', '.hssm-delete-slide', (e) => {
e.preventDefault(); e.preventDefault();
const slideId = $(e.currentTarget).data('slide-id'); const slideId = $(e.currentTarget).data('slide-id');
this.deleteSlide(slideId); this.deleteSlide(slideId);
}); });
// Duplicate slide $(document).off('click.hssmSlideActions', '.hssm-duplicate-slide').on('click.hssmSlideActions', '.hssm-duplicate-slide', (e) => {
$(document).off('click', '.hssm-duplicate-slide').on('click', '.hssm-duplicate-slide', (e) => {
e.preventDefault(); e.preventDefault();
const slideId = $(e.currentTarget).data('slide-id'); const slideId = $(e.currentTarget).data('slide-id');
this.duplicateSlide(slideId); this.duplicateSlide(slideId);
}); });
// Toggle status $(document).off('click.hssmSlideActions', '.hssm-toggle-status').on('click.hssmSlideActions', '.hssm-toggle-status', (e) => {
$(document).off('click', '.hssm-toggle-status').on('click', '.hssm-toggle-status', (e) => {
e.preventDefault(); e.preventDefault();
const slideId = $(e.currentTarget).data('slide-id'); const slideId = $(e.currentTarget).data('slide-id');
this.toggleSlideStatus(slideId); this.toggleSlideStatus(slideId);
@@ -1108,11 +1108,6 @@
$('#slide-forms-container').html(formHtml); $('#slide-forms-container').html(formHtml);
// Bind cancel edit events
$(document).on('click', '.hssm-cancel-edit, .hssm-cancel-edit-btn', this.cancelEdit.bind(this));
$(document).on('click', '.hssm-update-slide', this.updateSlide.bind(this));
$(document).on('click', '.hssm-schedule-updated-slide', this.scheduleUpdatedSlide.bind(this));
this.showMessage('Slide loaded for editing', 'success'); this.showMessage('Slide loaded for editing', 'success');
}, },
@@ -1137,19 +1132,22 @@
`).join(''); `).join('');
}, },
// Cancel edit mode // Cancel edit mode (silent: true skips toast — used after successful update so we do not double-message)
cancelEdit: function(e) { cancelEdit: function(e, silent) {
if (e) e.preventDefault(); if (e && e.preventDefault) {
e.preventDefault();
}
this.isEditMode = false; this.isEditMode = false;
this.editingSlideId = null; this.editingSlideId = null;
// Return to normal create form
$('#slide-forms-container').empty(); $('#slide-forms-container').empty();
this.formCounter = 0; this.formCounter = 0;
this.addInitialSlideForm(); this.addInitialSlideForm();
this.showMessage('Edit cancelled', 'info'); if (!silent) {
this.showMessage('Edit cancelled', 'info');
}
}, },
// Update slide function // Update slide function
@@ -1182,11 +1180,8 @@
if (response.success) { if (response.success) {
this.showMessage('Slide updated successfully as draft!', 'success'); this.showMessage('Slide updated successfully as draft!', 'success');
this.cancelEdit(null, true);
// Exit edit mode and refresh manage slides if that tab is available
this.cancelEdit();
// If manage slides tab exists, refresh it
if ($('#manage-slides').length > 0) { if ($('#manage-slides').length > 0) {
$('.hssm-nav-tabs a[data-tab="manage-slides"]').click(); $('.hssm-nav-tabs a[data-tab="manage-slides"]').click();
} }
@@ -1231,11 +1226,8 @@
if (response.success) { if (response.success) {
this.showMessage('Slide updated and scheduled for approval!', 'success'); this.showMessage('Slide updated and scheduled for approval!', 'success');
this.cancelEdit(null, true);
// Exit edit mode and refresh manage slides if that tab is available
this.cancelEdit();
// If manage slides tab exists, refresh it
if ($('#manage-slides').length > 0) { if ($('#manage-slides').length > 0) {
$('.hssm-nav-tabs a[data-tab="manage-slides"]').click(); $('.hssm-nav-tabs a[data-tab="manage-slides"]').click();
} }
@@ -1337,25 +1329,19 @@
// Show message to user // Show message to user
showMessage: function(message, type = 'info') { showMessage: function(message, type = 'info') {
const $messages = $('#hssm-messages'); const $messages = $('#hssm-messages');
const messageHtml = ` if (!$messages.length) {
<div class="hssm-message ${type}"> return;
${message} }
</div>
`;
$messages.append(messageHtml); const $msg = $('<div class="hssm-message"></div>').addClass(type).text(message);
$messages.append($msg);
// Auto-remove after 5 seconds const dismissMs = 5000;
setTimeout(() => { window.setTimeout(() => {
$messages.find('.hssm-message').last().fadeOut(300, function() { $msg.stop(true, true).fadeOut(300, function() {
$(this).remove(); $(this).remove();
}); });
}, 5000); }, dismissMs);
// Scroll to messages
$('html, body').animate({
scrollTop: $messages.offset().top - 20
}, 300);
}, },
// Placeholder methods for future implementation // Placeholder methods for future implementation